freebsd-current

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [PATCH]: if (cond); foo() in firewire Adrian Chadd Mon Jun 22 17:00:31 2009 

2009/6/22 Andriy Gapon <[EMAIL PROTECTED]>:
> You confuse me. It is a "vanilla userland transfer", but so?
> Current code always goes to "out" label regardless if uimove succeeded or not.
> I think the idea was to go "out" only if uimove failed and execute some code
> between if and out-label otherwise.

Because now you have a code path being run which hasn't been run for
quite a while.

I'm just saying be careful, and don't assume that "clang found a bug".
It found a bad code construct. Changing that bit of code changes the
flow of execution and may change things unexpectedly in later code.
It's the same with any bug - this "found by clang" bug should be
looked at by someone who knows the firewire code and they haven't
replied to this thread. :)

I'm glad clang has this lexical analysis magic. Shouldn't there be
some kind of weird, magical, standalone "lint" program to do this kind
of lexical checking for us? :)


Adrian




Adrian
_______________________________________________
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[EMAIL PROTECTED]"