google-caja-discuss

[Prev] Thread [Next]  |  [Prev] Date [Next]

[Caja] Issue 1061 in google-caja: experimental/prototype is busted - cannot run Prototype tests codesite-noreply Fri Jun 26 14:00:17 2009


Status: Accepted
Owner: ptwobrussell
Labels: Type-Defect Priority-Medium

New issue 1061 by ptwobrussell: experimental/prototype is busted - cannot run Prototype tests
http://code.google.com/p/google-caja/issues/detail?id=1061

What steps will reproduce the problem?

1. First remove the -a option from the caja.rb file since the -a option no longer exists.
Otherwise, you just get a bunch of log files with usage screens as output

2. Run build.sh (which in run runs Rakefile)

What is the expected output? What do you see instead?

Expected that you get good output showing that tests run w/o Exceptions

Instead you see

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1768)
        at com.google.caja.lang.html.HtmlSchema.elAndAttrib(HtmlSchema.java:268)
        at com.google.caja.lang.html.HtmlSchema.<init>(HtmlSchema.java:104)
        at com.google.caja.plugin.Config.getHtmlSchema(Config.java:172)
at com.google.caja.plugin.PluginCompilerMain.run(PluginCompilerMain.java:119) at com.google.caja.plugin.PluginCompilerMain.main(PluginCompilerMain.java:358)


The fix is to go into whitelist/html_attrib.json and change : to :: for separators. Apparently, this file didn't get updated when the separator changed in the past? Not sure what the history is on
that.

I will attempt to use the upload.py tool for code review and all that as a learning experience, so
please - no one beat me to it :)

Patch is inbound momentarily.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings