Loading...

connman@connman.net

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [PATCH] Ignore wext wireless rtnetlink events Marcel Holtmann Mon Mar 22 11:00:31 2010

Hi Samuel,

> The kernel wext core sends wireless events through the rtnetlink channel. They
> show up with the ifi_change field set to 0.
> The problem with those messages is that their ifi_flags might be
> unsynchronized due to the fact that the actual message sending is handled by a
> workqueue that doesnt build the message. ifi_flags is set to dev_flags, but by
> the time the message is sent dev_flags might have changed.
> connman should just ignore those messages as we don't care about wext events
> at all.
> ---
>  plugins/wifi.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/plugins/wifi.c b/plugins/wifi.c
> index 5fd82b0..dbe4abb 100644
> --- a/plugins/wifi.c
> +++ b/plugins/wifi.c
> @@ -94,6 +94,9 @@ static void wifi_newlink(unsigned flags, unsigned change, 
> void *user_data)
>  
>       DBG("index %d flags %d change %d", wifi->index, flags, change);
>  
> +     if (!change)
> +             return;
> +

I hope the kernel really uses the change event correctly. Otherwise we
miss events. Wouldn't it be easier to just ignore the WEXT events?

Regards

Marcel


_______________________________________________
connman mailing list
[EMAIL PROTECTED]
http://lists.connman.net/listinfo/connman