Loading...

dev@spamassassin.apache.org

[Prev] Thread [Next]  |  [Prev] Date [Next]

[Bug 6704] [review] Add /debian/ back to MANIFEST bugzilla-daemon Sat Nov 26 08:01:05 2011

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6704

Kevin A. McGrail <[EMAIL PROTECTED]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]

--- Comment #1 from Kevin A. McGrail <[EMAIL PROTECTED]> 2011-11-16 20:32:47 
UTC ---
> Add /debian/ to MANIFEST, remove it from MANIFEST.SKIP
> 
> 6 months ago I copied the latest Debian / Ubuntu (they've been the same for a
> while) packaging info ( /debian/ directory) into trunk, replacing an obsolete,
> broken /debian/ directory.  Around that time, /debian/ was also removed from
> the MANIFEST / tarball releases.  

...

> My reason for wanting to include it in the releases is because there have been
> numerous times in the past where I have needed to install something from a
> tarball, and been very pleased to find an included /debian/ directory allowing
> me to cleanly build a .deb instead of dealing with the other less pleasant
> options.  

Just to clarify, /debian/ was never in a previous release that I can find.  It
was added to support launchpad builds in trunk in Mid-May.

The MANIFEST however was incidentally edited from work on this bug
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6593 in Mid-May.

I then found including /debian/ wasn't in line with
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6647 to add the files to
trunk and the docs at http://wiki.apache.org/spamassassin/SyncDebianPackaging
which said to download trunk.

I then found issues when trying to fix hudson/jenkins because of MANFIEST and
MANIFEST.skip issues which led to debian having been added to the MANIFEST.

So I then removed /debian/ from the Manifest in Late-May in line with the
purpose being to support launchpad and be consistent with getting rid of OS
specific items in releases in the long-term.

If you read the chain of emails at
http://old.nabble.com/Updating-debian-build-directory--td31631485.html, it's
pretty clear that having it in trunk but not in releases was a compromise in
line with the consensus.

Synopsis: I am +1 for the tree remaining in trunk.  However, I'm leaning
towards removing all of the OS/distribution specific stuff from releases as
discussed prior and so I consider the current MANIFEST correct but will
withhold voting for others to chime in.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.