Loading...

google-caja-discuss@googlegroups.com

[Prev] Thread [Next]  |  [Prev] Date [Next]

[Caja] Re: Rework Server side CSS passes so CLASS and ID namespacing occurs in CSSRewriter (issue 5975048) mikesamuel Tue Apr 03 16:00:38 2012


http://codereview.appspot.com/5975048/diff/1009/src/com/google/caja/parser/css/CssTree.java
File src/com/google/caja/parser/css/CssTree.java (right):

http://codereview.appspot.com/5975048/diff/1009/src/com/google/caja/parser/css/CssTree.java#newcode1110
src/com/google/caja/parser/css/CssTree.java:1110: /** Equivalent to a
class with a blank prefix. */
On 2012/04/03 20:48:57, Jasvir wrote:
This comment threw me off for a while - probably should say a null
prefix.
Neither ClassLiteral nor IdLiteral can be blank - if not, we'd be
generating
malformed css.

Fixed

http://codereview.appspot.com/5975048/diff/1009/src/com/google/caja/parser/css/CssTree.java#newcode1168
src/com/google/caja/parser/css/CssTree.java:1168: // TODO: Would it help
if the render context specified the suffix?
On 2012/04/03 20:48:57, Jasvir wrote:
Seems unnecessary.

Yep.  Removed TODO.

http://codereview.appspot.com/5975048/diff/1009/tests/com/google/caja/plugin/css-stylesheet-tests.js
File tests/com/google/caja/plugin/css-stylesheet-tests.js (right):

http://codereview.appspot.com/5975048/diff/1009/tests/com/google/caja/plugin/css-stylesheet-tests.js#newcode167
tests/com/google/caja/plugin/css-stylesheet-tests.js:167: "golden":
".vdoc-body___.ie6.namespace__ p{color:blue}"
On 2012/04/03 20:48:57, Jasvir wrote:
Is vdoc-body still needed?

I don't know.

http://codereview.appspot.com/5975048/