Loading...

google-caja-discuss@googlegroups.com

[Prev] Thread [Next]  |  [Prev] Date [Next]

[Caja] Re: Namespace CSS selectors in sanitizecss.js (issue 5967066) mikesamuel Fri Apr 06 22:00:06 2012

On 2012/04/06 18:01:51, Jasvir wrote:
LGTM


http://codereview.appspot.com/5967066/diff/5003/src/com/google/caja/plugin/sanitizecss.js
File src/com/google/caja/plugin/sanitizecss.js (right):


http://codereview.appspot.com/5967066/diff/5003/src/com/google/caja/plugin/sanitizecss.js#newcode395
src/com/google/caja/plugin/sanitizecss.js:395: safeSelector =
'.vdoc-body___.' +
suffix + safeSelector.substring(4);
Can you add a TODO here to erradicate .vdoc-body___ handling.  I don't
see any
need for it any more.

Done.
I thought about excising it in these CLs, but I'm not convinced it's
useless.

body { font-family: Arial } is quite common, so it might be worth
generalizing to bodies without classes.

http://codereview.appspot.com/5967066/