Loading...

lilypond-devel@gnu.org

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: feta-accordion.mf, convertrules.py, musicxml2ly.py: sanitize accordion symbol names (issue1908041) n . puttock Thu Jul 29 13:02:23 2010 


http://codereview.appspot.com/1908041/diff/2001/3003
File python/convertrules.py (right):

http://codereview.appspot.com/1908041/diff/2001/3003#newcode3044
python/convertrules.py:3044: str = re.sub
(r'(\\musicglyph\s*#"accordion\.)([a-zA-Z]+)"',
Could be more generic, since it won't convert scheme markup:

(markup #:musicglyph "...")

or

(make-musicglyph-markup "...")

http://codereview.appspot.com/1908041/show

_______________________________________________
lilypond-devel mailing list
[EMAIL PROTECTED]
http://lists.gnu.org/mailman/listinfo/lilypond-devel