[Prev] Thread [Next]  |  [Prev] Date [Next]

Build: Remove .PRECIOUS flags. (issue 5688059) julien . rioux Tue Feb 21 03:00:08 2012

Reviewers: dak,

Please review.

Build: Remove .PRECIOUS flags.

Since 820c7ff5d380e8ca52057717ab3176b5e40107fd all files are treated as
.SECONDARY files. This means that `make' will not delete files that it
identifies as intermediate files, which would be it's default behavior

Currently, lexer and parser files, some font files, and some postscript
files are treated as .PRECIOUS in the build. This means that `make'
will never delete these files, even when the rule for creating them
failed. It seems that these files were flagged as .PRECIOUS in order
to keep them around after a successful build, preventing `make' from
removing them. But treating these files as .SECONDARY is sufficient
for this purpose. The .PRECIOUS flag introduces potential problems
that we would rather avoid.

Please review this at http://codereview.appspot.com/5688059/

Affected files:
  M lily/GNUmakefile
  M make/mutopia-targets.make
  M mf/GNUmakefile

Index: lily/GNUmakefile
diff --git a/lily/GNUmakefile b/lily/GNUmakefile
index ea7785b947c687e39f0ce73cb5c94b29600bb657..1872af74ce740499b504667e426d916c0935a12c 100644
--- a/lily/GNUmakefile
+++ b/lily/GNUmakefile
@@ -86,9 +86,3 @@ $(outdir)/relocate.o: $(outdir)/version.hh
 $(outdir)/warn-scheme.o: $(outdir)/version.hh

 local-po: $(outdir)/parser.cc
-# ugh.  For --srcdir builds, these must exist to satisfy their broken
-# lexer.dep and parser.dep file entries.
-ifneq ($(configure-srcdir),.)
-.PRECIOUS: $(outdir)/lexer.cc $(outdir)/parser.cc
Index: make/mutopia-targets.make
diff --git a/make/mutopia-targets.make b/make/mutopia-targets.make
index 4eeb80ed0c32a9768f3438cc88a3172d14c7ff3e..0d49357e46bb85bcce3a790057f138058119c809 100644
--- a/make/mutopia-targets.make
+++ b/make/mutopia-targets.make
@@ -1,8 +1,5 @@
 .PHONY: download mutopia png ps scores tar

-.PRECIOUS: $(outdir)/%.ps $(outdir)/%-book.ps
-.PRECIOUS: $(outdir)-letter/%.ps


Index: mf/GNUmakefile
diff --git a/mf/GNUmakefile b/mf/GNUmakefile
index 97bcd42ef4f18d0d54f2ff9aeb6426e49b5eac70..ad397159c382974c600e5a4746fcd57bf4916dc9 100644
--- a/mf/GNUmakefile
+++ b/mf/GNUmakefile
@@ -163,8 +163,6 @@ $(PE_SCRIPTS): $(buildscript-dir)/gen-emmentaler-scripts
 PFB_FILES = $(ALL_FONTS:%=$(outdir)/%.pfb)


 # Make tfm files first, log files last,
 # so that normally log files aren't made twice

lilypond-devel mailing list