Loading...

lilypond-devel@gnu.org

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: Gets vertical skylines from grob stencils (issue 5626052) joeneeman Wed Feb 22 02:00:42 2012


http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc
File lily/skyline.cc (right):

http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode393
lily/skyline.cc:393: Skyline::Skyline (Building b, Real start, Axis
horizon_axis, Direction sky)
This isn't quite what I had in mind (for one thing, it means that the
caller has to be aware of buildings, calculating their slope, etc.)

what about
Skyline::Skyline (vector<pair<Point, Point> > const& segments, Axis,
Direction)?

it works similarly to Skyline::Skyline(vector<Box>...) except that the
resulting skyline shows the outline of the given set of line segments.

http://codereview.appspot.com/5626052/diff/30003/lily/skyline.cc#newcode647
lily/skyline.cc:647: out.merge (to_merge);
merge is linear, so this loop is quadratic.

http://codereview.appspot.com/5626052/

_______________________________________________
lilypond-devel mailing list
[EMAIL PROTECTED]
https://lists.gnu.org/mailman/listinfo/lilypond-devel