[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [MPlayer-dev-eng] [PATCH] Fix NAS ao for small files. Tobias Diedrich Fri Aug 15 15:00:27 2008

Diego Biurrun wrote:
> On Fri, Aug 15, 2008 at 06:23:03PM +0200, Tobias Diedrich wrote:
> > 
> > someone pointed out to me that the NAS ao does not work correctly
> > with very small .wav files (or really anything where less than
> > outburst is to be played).
> > 
> > The attached patch should fix that (and has been lying on my disk a
> > bit long, but still applies to current svn).
> Applied, you are the maintainer.  I assume that you never received a new
> account after the Subversion migration?

Yeah well no, if you want to give me one, go ahead, but I rarely
find time to fiddle with MPlayer these days unfortunately...
So I guess we might be talking about once in a year or so commits
here. :)

> While we're talking about ao_nas: It prints a lot of warnings, including
> some void* arithmetic warnings.  Maybe you could look into fixing this.

Sure, I can do that.
Hmm, I don't see any void* warnings, do I have to enable some debug
The build-system uses "cc -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -std=gnu99 -I. -W -Wall -O2
-march=native -mtune=native -pipe -g  -D_REENTRANT
-I/usr/include/freetype2   -c -o libao2/ao_nas.o libao2/ao_nas.c"
and cc is "cc (Debian 4.3.1-2) 4.3.1".

Patch for 'comparison between signed and unsigned' attached.

BTW, ao_oss gives me a "cast from pointer to integer of different
size" on line 169 (because I'm on amd64 and void* is cast to int).

Tobias                                          PGP: http://9ac7e0bc.uguu.de
MPlayer-dev-eng mailing list