Loading...

mplayer-dev-eng@mplayerhq.hu

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [MPlayer-dev-eng] [PATCH] libmpdemux/demux_audio: Skip ID3v2.4 tags. Reimar Döffinger Fri Feb 03 20:07:57 2012

On Fri, Jan 27, 2012 at 02:06:31PM +0100, Benoît Thébaudeau wrote:
> diff -Nrdup mplayer.orig/libmpdemux/demux_audio.c 
> mplayer/libmpdemux/demux_audio.c
> --- mplayer.orig/libmpdemux/demux_audio.c     2012-01-27 13:42:31.522983827 
> +0100
> +++ mplayer/libmpdemux/demux_audio.c  2012-01-27 13:55:08.946980169 +0100
> @@ -441,12 +441,12 @@ static int demux_audio_open(demuxer_t* d
>      free(mp3_found);
>      mp3_found = NULL;
>      if(s->end_pos && (s->flags & MP_STREAM_SEEK) == MP_STREAM_SEEK) {
> -      stream_seek(s,s->end_pos-128);
> +      stream_seek(s,demuxer->movi_end-128);

Semantics-wise, it doesn't really make sense to check
for s->end_pos but then use demuxer->movi_end.
Also I realize that it would probably make sense to check
for it >/>= 128.
_______________________________________________
MPlayer-dev-eng mailing list
[EMAIL PROTECTED]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng