Loading...

mplayer-dev-eng@mplayerhq.hu

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [MPlayer-dev-eng] [RFC][PATCH V2] libmpcodecs/ad_spdif.c check DTS profile compn Thu Feb 09 09:01:57 2012

On Thu, 9 Feb 2012 23:31:46 +0900, Naoya OYAMA wrote:
>
>Hi,
>patch updated.


your patch mixes lots of different things together, including cosmetics.


>-        { "aac" , CODEC_ID_AAC    },
>-        { "ac3" , CODEC_ID_AC3    },
>-        { "dca" , CODEC_ID_DTS    },
>-        { "eac3", CODEC_ID_EAC3   },
>-        { "mpa" , CODEC_ID_MP3    },
>-        { "thd" , CODEC_ID_TRUEHD },
>-        { NULL  , 0 }
>+        { "aac"   , CODEC_ID_AAC    },
>+        { "ac3"   , CODEC_ID_AC3    },
>+        { "dca"   , CODEC_ID_DTS    },
>+        { "eac3"  , CODEC_ID_EAC3   },
>+        { "mp3"   , CODEC_ID_MP3    },
>+        { "truehd", CODEC_ID_TRUEHD },
>+        { NULL    , 0 }


changing mpa > mp3 and thd > truehd LGTM.


>Index: etc/codecs.conf
>===================================================================
>--- etc/codecs.conf    (revision 34665)
>+++ etc/codecs.conf    (working copy)
>@@ -5556,7 +5556,7 @@
>   fourcc ".mp1"      ; MP1 (MOV files)
>   fourcc "MP3 "      ; used in .nsv files
>   fourcc "LAME"      ; used in mythtv .nuv files
>-  dll    mpa
>+  dll    mp3
>   driver spdif
> 
> audiocodec spdifthd
>@@ -5564,7 +5564,7 @@
>   status working
>   comment "needs -channels 8"
>   fourcc TRHD ; internal MPlayer FourCC
>-  dll    thd
>+  dll    truehd
>   driver spdif

this is OK.

i cannot review the rest of your patch, as i dont know the code.

-compn
_______________________________________________
MPlayer-dev-eng mailing list
[EMAIL PROTECTED]
https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng