Loading...

mythtv-dev@mythtv.org

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: [mythtv] Ticket #10008: mythtranscode: picture corruption and momentary stalling after cuts Daniel Kristjansson Fri Feb 03 05:12:16 2012

On Mon, 2012-01-30 at 12:27 +0000, Paul Gardiner wrote:
> On 30/01/2012 12:10, MythTV wrote:
> > #10008: mythtranscode: picture corruption and momentary stalling after cuts
> > ----------------------------------+-----------------------------
> >   This appears to have introduced two new complaints in the cppcheck report.
> That will be my fault. I'm afraid I don't know what cppcheck is, but if
> someone could give a brief explanation, I could try to fix the problems.
> Or, if someone else fixes them, please say what they were, so that I
> can endeavour to avoid the same problems in future patches.

cppcheck is a static analysis tool we run on the code.

You can see the latest results here:
  http://code.mythtv.org/cppcheck/

Search for transcode.cpp in the report to find both.

In this case there appears to be an uninitialized variable
in the constructor and a non-const method that doesn't modify
the instance; that one should probably have a 
"GetAdjustedCutList(void) const" signature.

-- Daniel

_______________________________________________
mythtv-dev mailing list
[EMAIL PROTECTED]
http://www.mythtv.org/mailman/listinfo/mythtv-dev