Loading...

repo-discuss@googlegroups.com

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: trivial rebase script problem Philipp Altmann Sat Feb 18 06:01:34 2012

Hi JT Olds,

but we are talking about 2.2.2.x not 2.2.1.

Cheers
Philipp

2:55, JT  Olds <[EMAIL PROTECTED]> wrote:
> Um, from your traceback I don't see enough detail to figure out what's
> going on with your trivial rebase script configuration, but I got mine
> configured just fine with 2.2.1
>
> I made sure there was a "gerrit" user in Gerrit (henceforth referred
> to as Gerrit-gerrit), with a new ssh key that the user running gerrit
> (referred to as linux-gerrit) on the host box's ssh config knew about
> (so, ~gerrit/.ssh/id_rsa). Then I made sure the Gerrit-gerrit user was
> in the Administrators group.
>
> Last, I needed to run the trivial rebase script with --private-key-
> path $site/etc/ssh_host_dsa_key
>
> All seems to be good to me. It might be helpful if you provided more
> detail from your gerrit log, but I don't think compatibility with
> 2.2.x is the issue.
>
> On Feb 14, 3:15 am, Philipp Altmann <[EMAIL PROTECTED]> wrote:
>
>
>
>
>
>
>
> > Hi,
>
> > there are any news on this issue?
>
> > Cheers
> > Philipp
>
> > On Jan 23, 6:30 pm, Nasser Grainawi <[EMAIL PROTECTED]> wrote:> We haven't 
> > upgraded to 2.2.2 internally yet, so I haven't updated the script. We'll 
> > (hopefully) be upgrading in the next few weeks and I'll post the updated 
> > script version with instructions then.
>
> > > Nasser
>
> > > On Jan 21, 2012, at 6:49 AM, Lazo Apostolovski wrote:
>
> > > > Hi
>
> > > > I try to integrate trivial_rebase.py script for patchset-created hook 
> > > > on gerrit, and I have a couple of problems with that.
>
> > > > I created separate new user on gerrit for this and I gives him admin 
> > > > rights (its in Administrators group).
>
> > > > At first when I upload new patch sets suexec command is executed 
> > > > withTraceback (most recent call last):
>
> > > > (['ssh', '-l', 'Gerrit Code Review', '-p', '29418', 'localhost', '-i', 
> > > > '/home/qbox/.ssh/id_rsa', 'suexec', '--as', u'[EMAIL PROTECTED]', '--', 
> > > > u"gerrit approve --project testproject --message 'Automatically 
> > > > re-added by Gerrit trivial rebase detection script.' --code-review 1 
> > > > 526930264d146823f62be809dfa3c02a215b39cd"]
>
> > > > I see in gerrit sshd_log that user try to log with "Gerrit Code Review" 
> > > > username. I change this with appropriate username and try again. I do 
> > > > some comments on previous patch set and set code review on +1. I do 
> > > > some changes, rebase and push it again. New patch set was created but 
> > > > my commit messages has not been copied. I see in error.log and I see 
> > > > this message:
>
> > > >   File "/home/qbox/gerrit/Dzjinn/hooks/trivial_rebase.py", line 226, in 
> > > > <module>
> > > >     Main()
> > > >   File "/home/qbox/gerrit/Dzjinn/hooks/trivial_rebase.py", line 222, in 
> > > > Main
> > > >     ' '.join(gerrit_approve_cmd))
> > > >   File "/home/qbox/gerrit/Dzjinn/hooks/trivial_rebase.py", line 127, in 
> > > > SuExec
> > > >     CheckCall(suexec_cmd)
> > > >   File "/home/qbox/gerrit/Dzjinn/hooks/trivial_rebase.py", line 63, in 
> > > > CheckCall
> > > >     raise CheckCallError(command, cwd, process.returncode, std_out, 
> > > > std_err)
> > > > __main__.CheckCallError: (['ssh', '-l', 'appropriateusername', '-p', 
> > > > '29418', 'localhost', '-i', '/home/qbox/.ssh/id_rsa', 'suexec', '--as', 
> > > > u'[EMAIL PROTECTED]', '--', u"gerrit approve --project testproject 
> > > > --code-review 1 5ac66c3e58ad14e76afdae6b0be9afb2e69fad64 --message 
> > > > 'Automatically re-added by Gerrit trivial rebase detection script.'"], 
> > > > None, 1, '', None)
>
> > > > any suggestions?
>
> > > > Thank you.
>
> > > > --
> > > > To unsubscribe, email [EMAIL PROTECTED]
> > > > More info athttp://groups.google.com/group/repo-discuss?hl=en
>
> > > --
> > > Employee of Qualcomm Innovation Center, Inc.
> > > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

-- 
To unsubscribe, email [EMAIL PROTECTED]
More info at http://groups.google.com/group/repo-discuss?hl=en