Loading...

repo-discuss@googlegroups.com

[Prev] Thread [Next]  |  [Prev] Date [Next]

Re: Querying changes in gerrit source code Conley Owens Thu Feb 23 12:01:39 2012

Thanks, I'll do the refactoring and look into ChangeListServiceImpl.

On Thu, Feb 23, 2012 at 11:53 AM, Shawn Pearce <[EMAIL PROTECTED]> wrote:
> On Thu, Feb 23, 2012 at 11:27, Conley Owens <[EMAIL PROTECTED]> wrote:
>> As part a patch I'm working on, I'd like to be able to make a query
>> and get a list of changes.  There's a ChangeQueryBuilder i can use
>> directly, but it doesn't seem to do everything I'd like (such as
>> enforcing limits).  There's also the QueryProcessor, which uses the
>> ChangeQueryBuilder, but seems to be made for directly outputting the
>> results as TEXT or JSON.  Which makes the most sense?
>>
>> * Leave everything like it is -- use the ChangeQueryBuilder directly,
>> doing post processing myself
>> * Refactor the logic of the QueryProcessor so that the portion of code
>> that actually performs the query and does the post processing lives in
>> its own method -- use that method
>
> Without even opening the code (so I may be wrong here!) I think this
> is the strategy that makes the most sense. I actually need this same
> thing for something else internally at Google. So it would be great if
> you could do the refactoring for me.  :-)
>
> Actually, the ChangeListServiceImpl should use QueryProcessor. And it
> might not, simply because of this same problem you are seeing. So it
> may be worth the refactoring.

-- 
To unsubscribe, email [EMAIL PROTECTED]
More info at http://groups.google.com/group/repo-discuss?hl=en